Skip to content

Fix platform handling #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2020
Merged

Fix platform handling #1136

merged 1 commit into from
Nov 22, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Oct 27, 2020 •
edited
Loading

  • Remove unused platforms tab on /crate page. We always show platforms, even on rustdoc pages.
  • Don't show the platform dropdown if it's empty.
  • Add a test

Fixes #1111.

@jyn514 jyn514 added C-bug Category: This is a bug S-waiting-on-author Status: This PR is incomplete or needs to address review comments A-backend Area: Webserver backend labels Oct 27, 2020
Nemo157
Nemo157 reviewed Oct 27, 2020
View reviewed changes
@jyn514
Fix platform handling
233f132 
- Remove unused platforms tab on /crate page. We always show platforms,
  even on rustdoc pages.
- Don't show the platform dropdown if it's empty.
- Add a test
@jyn514 jyn514 changed the title [WIP] Fix platform handling Fix platform handling Nov 22, 2020
@jyn514 jyn514 added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Nov 22, 2020
@jyn514
Copy link
Member Author

jyn514 commented Nov 22, 2020

This is ready for review.

@jyn514 jyn514 merged commit a86aba3 into rust-lang:master Nov 22, 2020
@jyn514 jyn514 deleted the platforms branch November 22, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nemo157 Nemo157 Nemo157 approved these changes

Assignees
No one assigned
Labels
A-backend Area: Webserver backend C-bug Category: This is a bug S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Platform" button unresponsive with no targets
2 participants
@jyn514 @Nemo157